Fix creation performance of form element menuparent, (slow down in menu item edit form, for item that belongs to large menu) #11628

ggppdk · 2016-08-16T09:40:43Z

Fix creation performance of form element menuparent

used in menu item edit form

Summary of Changes

Remove unused left join in getOptions for menuparent form element

No reason because for it being there because

Join is left
The results of the join are not used anywhere neither in select nor where and not in any other clause
There is no PHP code that adds some usage of it under some condition

Testing Instructions

Visit menu item edit form and, check parent menuitem form field is as before

Documentation Changes Required

ggppdk · 2016-08-16T11:05:08Z

1 more optimization, replaced unneeded
group by with distinct

For reasoning behind the above,

and for when the above can be done without problems

please see my comment here for similar fix in :
#9516 (comment)

which was followed by @alikon making a similar PR, that was tested and merged, see here:
#9689

(and there maybe 1 or 2 more places that need similar changes)

brianteeman · 2016-08-16T11:38:57Z

Needs to be checked on all databases

On 16 August 2016 at 12:05, Georgios Papadakis notifications@github.com
wrote:

1 more optimization, replaced unneeded
group by with distinct

For reasoning behind the above,

and for when the above can be done without problems

please see my comment here for similar fix in :
#9516 (comment)
#9516 (comment)

which was followed by @alikon https://github.com/alikon making a
similar PR here , that was merged:
#9689 #9689

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11628 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8TOWzIewyv1IKoTNKMeoDiJfOOsIks5qgZlngaJpZM4JlNVu
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

jeckodevelopment · 2016-08-17T12:35:51Z

Needs to be checked on all databases

@alikon can you help with this, please?

prathumwan · 2016-08-17T17:31:54Z

could not measure it with debug because running out of memory, but if you see the result done by hand it's a big improvement.

select order by result:

select distinct result:

alikon · 2016-08-17T19:37:14Z

in postgresql don't work as it is now , it give an SQL ERROR
for the ORDER BY clause field is used a.lft and therefore must be in the select list of fields when the SELECT use DISTINCT()

@ggppdk i've submitted a PR ggppdk#2 to your branch with the fix for postgresql

@jeckodevelopment always happy to help when free time permits ;)

in postgresql don't work as it is now , it give an **SQL ERROR** for the `ORDER BY` clause field used `a.lft` must be in the select list of fields when the `SELECT` use `DISTINCT()`

ggppdk · 2016-08-17T19:39:26Z

@alikon
Merged, thanks

alikon · 2016-08-17T19:50:35Z

@ggppdk thanks,
for the perfomance, have someone, some "decent" menu table dump to meter ?

p.s.
this query is still ugly a.published != -2 for example. etc...

jeckodevelopment · 2016-08-17T19:58:59Z

@alikon you're our DB expert :) thank you

ggppdk · 2016-08-17T20:30:13Z

this query is still ugly a.published != -2 for example. etc...

ok but nothing significant to further improve performance

these 2 changes are enough to fix the performance issue, on large menu (with a few thousands of menu items)

removal of unsed self-join with the full table (unlike to the "parent" join that limits to -specific- row id)
the replacement of group-by with distinct , since we do not do use any aggregating function to calculate something

alikon · 2016-08-18T17:44:33Z

I have tested this item ✅ successfully on 2972851

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11628.}

prathumwan · 2016-08-19T04:55:52Z

I have tested this item ✅ successfully on 2972851

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11628.}

andrepereiradasilva · 2016-08-21T22:03:42Z

can we have RTC here?

brianteeman · 2016-08-21T22:17:45Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11628.}

…nu item edit form, for item that belongs to large menu) (joomla#11628) * Remove unused left join in getOptions for menuparent form element * Replaced unneeded group by with distinct * fix joomla#11628 for postgresql (#2) in postgresql don't work as it is now , it give an **SQL ERROR** for the `ORDER BY` clause field used `a.lft` must be in the select list of fields when the `SELECT` use `DISTINCT()`

…areable-draft-content * origin/shareable-draft-content: (245 commits) Implement shareable draft links Cleaned up shared drafts view Added front-end token generarion Implement shared drafts view Remove obsolete file use only root (joomla#11703) com_search category results not displaying date (joomla#11802) warnings and errors, not notices ... (joomla#11801) [installation] Add javascript message titles and ajax errors strings (joomla#11800) Regression: Normalising head links and correcting hreflang for menu items associations (joomla#11769) Refactor allowEdit of backend category controller (joomla#11547) [com_contact] Move event trigger to correct place (joomla#11719) Improve the accessibility of the top menu in ISIS part 2 (joomla#11729) Show file extension (joomla#11776) change button -> a for the modal close button (joomla#11787) Small Grammar change (joomla#11788) Change message type to error when download of update package fails (joomla#11791) these are warnings not messages ... (joomla#11799) [plg_content_vote|pagebreak] Load language files only when needed (joomla#11730) [plg_system_stats] Load plugin language files only when needed (joomla#11728) Fix creation performance of form element menuparent, (slow down in menu item edit form, for item that belongs to large menu) (joomla#11628) ... # Conflicts: # administrator/components/com_admin/script.php # administrator/components/com_content/models/shared.php # administrator/components/com_content/views/shared/tmpl/default.php # administrator/language/en-GB/en-GB.xml # administrator/language/en-GB/install.xml # administrator/manifests/files/joomla.xml # administrator/manifests/packages/pkg_en-GB.xml # installation/language/en-GB/en-GB.xml # language/en-GB/en-GB.xml # language/en-GB/install.xml # libraries/cms/pagination/pagination.php # libraries/cms/version/version.php # libraries/joomla/authentication/authentication.php # libraries/joomla/form/fields/color.php # libraries/joomla/form/fields/email.php # media/system/js/share-uncompressed.js # media/system/js/share.js # plugins/content/vote/vote.php

Remove unused left join in getOptions for menuparent form element

0d456a3

joomla-cms-bot added the PR-staging label Aug 16, 2016

ggppdk changed the title ~~Fix creation performance of form element menuparent Remove unused left join in getOptions for menuparent form element~~ Fix creation performance of form element menuparent, removing unused left join in getOptions for menuparent form element Aug 16, 2016

ggppdk changed the title ~~Fix creation performance of form element menuparent, removing unused left join in getOptions for menuparent form element~~ Fix creation performance of form element menuparent, (used in menu item edit form) Aug 16, 2016

Replaced unneeded group by with distinct

8754f10

ggppdk changed the title ~~Fix creation performance of form element menuparent, (used in menu item edit form)~~ Fix creation performance of form element menuparent, (slow down in menu item edit form, for item that belongs to large menu) Aug 17, 2016

ggppdk mentioned this pull request Aug 17, 2016

Fix performance retrieving menu items in menus helper, e.g. when creating "Select page" filter in modules manager #11627

Merged

alikon mentioned this pull request Aug 17, 2016

fix #11628 for postgresql ggppdk/joomla-cms#2

Merged

fix joomla#11628 for postgresql (#2)

2972851

in postgresql don't work as it is now , it give an **SQL ERROR** for the `ORDER BY` clause field used `a.lft` must be in the select list of fields when the `SELECT` use `DISTINCT()`

ggppdk mentioned this pull request Aug 18, 2016

joomla backend get slow with a lot of menu items #10997

Closed

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 21, 2016

rdeutz added this to the Joomla 3.6.3 milestone Aug 25, 2016

rdeutz merged commit 99a76db into joomla:staging Aug 25, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 25, 2016

ggppdk deleted the patch-24 branch August 25, 2016 21:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix creation performance of form element menuparent, (slow down in menu item edit form, for item that belongs to large menu) #11628

Fix creation performance of form element menuparent, (slow down in menu item edit form, for item that belongs to large menu) #11628

ggppdk commented Aug 16, 2016 •

edited by brianteeman

Loading

ggppdk commented Aug 16, 2016 •

edited

Loading

brianteeman commented Aug 16, 2016

jeckodevelopment commented Aug 17, 2016

prathumwan commented Aug 17, 2016

alikon commented Aug 17, 2016

ggppdk commented Aug 17, 2016 •

edited

Loading

alikon commented Aug 17, 2016

jeckodevelopment commented Aug 17, 2016

ggppdk commented Aug 17, 2016 •

edited

Loading

alikon commented Aug 18, 2016

prathumwan commented Aug 19, 2016

andrepereiradasilva commented Aug 21, 2016

brianteeman commented Aug 21, 2016

Fix creation performance of form element menuparent, (slow down in menu item edit form, for item that belongs to large menu) #11628

Fix creation performance of form element menuparent, (slow down in menu item edit form, for item that belongs to large menu) #11628

Conversation

ggppdk commented Aug 16, 2016 • edited by brianteeman Loading

Summary of Changes

Testing Instructions

Documentation Changes Required

ggppdk commented Aug 16, 2016 • edited Loading

brianteeman commented Aug 16, 2016

jeckodevelopment commented Aug 17, 2016

prathumwan commented Aug 17, 2016

alikon commented Aug 17, 2016

ggppdk commented Aug 17, 2016 • edited Loading

alikon commented Aug 17, 2016

jeckodevelopment commented Aug 17, 2016

ggppdk commented Aug 17, 2016 • edited Loading

alikon commented Aug 18, 2016

prathumwan commented Aug 19, 2016

andrepereiradasilva commented Aug 21, 2016

brianteeman commented Aug 21, 2016

ggppdk commented Aug 16, 2016 •

edited by brianteeman

Loading

ggppdk commented Aug 16, 2016 •

edited

Loading

ggppdk commented Aug 17, 2016 •

edited

Loading

ggppdk commented Aug 17, 2016 •

edited

Loading